Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: VLAN reserve range side panels #5389

Merged
merged 4 commits into from
Apr 8, 2024
Merged

fix: VLAN reserve range side panels #5389

merged 4 commits into from
Apr 8, 2024

Conversation

petermakowski
Copy link
Contributor

Done

  • fix: VLAN reserve range side panels
    • move SubnetActionForms.tsx out of the header directory

QA steps

  • Go to a VLAN details page (e.g. /MAAS/r/vlan/35 in demos)
  • Click reserve range
  • Verify you can submit the form and range is added to the list
  • Ensure you can edit and delete it successfully
  • Add a new VLAN and ensure that Delete VLAN side panel works correctly

Screenshots

Notes

@webteam-app
Copy link

Demo

Jenkins

demos.haus

@petermakowski petermakowski marked this pull request as ready for review April 5, 2024 14:16
@ndv99
Copy link
Contributor

ndv99 commented Apr 5, 2024 •
edited
Loading

I can delete a reserved range successfully, but the side panel does not close after this.

@petermakowski
fix: side panel close on submit
56c8ad1 
- refactor: use explicit prop names for vland and subnet
@petermakowski petermakowski force-pushed the fix-vlan-reserve-range-side-panels branch from 7798ed9 to 56c8ad1 Compare April 5, 2024 15:03
@ndv99
Copy link
Contributor

ndv99 commented Apr 8, 2024

Idk if this is just happening for me, but I'm still getting the issue with the "Delete reserved range" side panel not closing on success

ndv99
ndv99 approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@ndv99 ndv99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermakowski petermakowski merged commit a0347b4 into canonical:main Apr 8, 2024
6 checks passed
@petermakowski petermakowski deleted the fix-vlan-reserve-range-side-panels branch May 9, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndv99 ndv99 ndv99 approved these changes

@Jay-Topher Jay-Topher Awaiting requested review from Jay-Topher

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@petermakowski @webteam-app @ndv99 @Jay-Topher